Closed
Conversation
closes #15066 The difficult part here is only calculate line ending at the really end, just before write, to avoid memory allocations on the source text when you insert a newline. @leaysgur This feature also requires a single file formatter so we can apply this to node API and file system write. The single file formatter need to accept a `Writer` so we can write to string or file.
github-actions
bot
added
A-cli
CodSpeed Performance ReportMerging #16757 will not alter performanceComparing Summary
Footnotes
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #15066
The difficult part here is only calculate line ending at the really end, just before write, to avoid memory allocations on the source text when you insert a newline.
@leaysgur This feature also requires a single file formatter so we can apply this to node API and file system write. The single file formatter need to accept a
Writerso we can write to string or file.